diff options
| author | Baokun Li <libaokun1@huawei.com> | 2024-08-22 10:35:34 +0800 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2024-09-03 22:12:17 -0400 |
| commit | f7d1331f16a869c76a5102caebb58e840e1d509c (patch) | |
| tree | 0398eda70a6684672b58f9b962a0563651dda2ad /fs/ext4/fast_commit.c | |
| parent | a000bc8678cc2bb10a5b80b4e991e77c7b4612fd (diff) | |
| download | linux-f7d1331f16a869c76a5102caebb58e840e1d509c.tar.gz linux-f7d1331f16a869c76a5102caebb58e840e1d509c.tar.bz2 linux-f7d1331f16a869c76a5102caebb58e840e1d509c.zip | |
ext4: get rid of ppath in ext4_ext_insert_extent()
The use of path and ppath is now very confusing, so to make the code more
readable, pass path between functions uniformly, and get rid of ppath.
To get rid of the ppath in ext4_ext_insert_extent(), the following is done
here:
* Free the extents path when an error is encountered.
* Its caller needs to update ppath if it uses ppath.
* Free path when npath is used, free npath when it is not used.
* The got_allocated_blocks label in ext4_ext_map_blocks() does not
update err now, so err is updated to 0 if the err returned by
ext4_ext_search_right() is greater than 0 and is about to enter
got_allocated_blocks.
No functional changes.
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Tested-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Link: https://patch.msgid.link/20240822023545.1994557-15-libaokun@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/fast_commit.c')
| -rw-r--r-- | fs/ext4/fast_commit.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c index 326c16a4e51e..afcb2e5cdac7 100644 --- a/fs/ext4/fast_commit.c +++ b/fs/ext4/fast_commit.c @@ -1803,12 +1803,12 @@ static int ext4_fc_replay_add_range(struct super_block *sb, if (ext4_ext_is_unwritten(ex)) ext4_ext_mark_unwritten(&newex); down_write(&EXT4_I(inode)->i_data_sem); - ret = ext4_ext_insert_extent( - NULL, inode, &path, &newex, 0); + path = ext4_ext_insert_extent(NULL, inode, + path, &newex, 0); up_write((&EXT4_I(inode)->i_data_sem)); - ext4_free_ext_path(path); - if (ret) + if (IS_ERR(path)) goto out; + ext4_free_ext_path(path); goto next; } |