diff options
| author | Eryu Guan <guaneryu@gmail.com> | 2015-07-28 15:08:41 -0400 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2015-07-28 15:08:41 -0400 |
| commit | 911af577de4e444622d46500c1f9a37ab4335d3a (patch) | |
| tree | 5261fa696f6c26f21202578b08888b0b17077deb /fs/ext4/inode.c | |
| parent | 841df7df196237ea63233f0f9eaa41db53afd70f (diff) | |
| download | linux-911af577de4e444622d46500c1f9a37ab4335d3a.tar.gz linux-911af577de4e444622d46500c1f9a37ab4335d3a.tar.bz2 linux-911af577de4e444622d46500c1f9a37ab4335d3a.zip | |
ext4: update c/mtime on truncate up
Commit 3da40c7b0898 ("ext4: only call ext4_truncate when size <= isize")
introduced a bug that c/mtime is not updated on truncate up.
Fix the issue by setting c/mtime explicitly in the truncate up case.
Note that ftruncate(2) is not affected, so you won't see this bug using
truncate(1) and xfs_io(1).
Signed-off-by: Zirong Lang <zorro.lang@gmail.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/inode.c')
| -rw-r--r-- | fs/ext4/inode.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index cecf9aa10811..2442eb065e19 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -4725,6 +4725,14 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr) error = ext4_orphan_add(handle, inode); orphan = 1; } + /* + * Update c/mtime on truncate up, ext4_truncate() will + * update c/mtime in shrink case below + */ + if (!shrink) { + inode->i_mtime = ext4_current_time(inode); + inode->i_ctime = inode->i_mtime; + } down_write(&EXT4_I(inode)->i_data_sem); EXT4_I(inode)->i_disksize = attr->ia_size; rc = ext4_mark_inode_dirty(handle, inode); |