summaryrefslogtreecommitdiffstats
path: root/fs/f2fs/gc.c
diff options
context:
space:
mode:
authorChao Yu <yuchao0@huawei.com>2017-11-03 10:21:05 +0800
committerJaegeuk Kim <jaegeuk@kernel.org>2017-11-05 16:42:10 -0800
commitbb06664a534ba4833373f19ae018efff91ab2908 (patch)
tree5c8ff095ec9ebae04cad4fcf440eb6ca90caa2f1 /fs/f2fs/gc.c
parentf6986ede80c9a03babb1cff870964f4de1e763e8 (diff)
downloadlinux-bb06664a534ba4833373f19ae018efff91ab2908.tar.gz
linux-bb06664a534ba4833373f19ae018efff91ab2908.tar.bz2
linux-bb06664a534ba4833373f19ae018efff91ab2908.zip
f2fs: avoid race in between GC and block exchange
During block exchange in {insert,collapse,move}_range, page-block mapping is unstable due to mapping moving or recovery, so there should be no concurrent cache read operation rely on such mapping, nor cache write operation to mess up block exchange. So this patch let background GC be aware of that. Signed-off-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/gc.c')
-rw-r--r--fs/f2fs/gc.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index ff8f0012888d..5d5bba462f26 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -832,10 +832,17 @@ next_step:
continue;
}
+ if (!down_write_trylock(
+ &F2FS_I(inode)->dio_rwsem[WRITE])) {
+ iput(inode);
+ continue;
+ }
+
start_bidx = start_bidx_of_node(nofs, inode);
data_page = get_read_data_page(inode,
start_bidx + ofs_in_node, REQ_RAHEAD,
true);
+ up_write(&F2FS_I(inode)->dio_rwsem[WRITE]);
if (IS_ERR(data_page)) {
iput(inode);
continue;