diff options
| author | Hou Tao <houtao1@huawei.com> | 2024-05-09 20:21:53 +0800 |
|---|---|---|
| committer | Miklos Szeredi <mszeredi@redhat.com> | 2024-05-10 11:10:12 +0200 |
| commit | 42815f8ac54c5113bf450ec4b7ccc5b62af0f6a7 (patch) | |
| tree | 8df8c33c284abaf45f9ac976cacd4171b55c49ce /fs/fuse | |
| parent | 9fe2a036a23ceeac402c4fde8ec37c02ab25f133 (diff) | |
| download | linux-42815f8ac54c5113bf450ec4b7ccc5b62af0f6a7.tar.gz linux-42815f8ac54c5113bf450ec4b7ccc5b62af0f6a7.tar.bz2 linux-42815f8ac54c5113bf450ec4b7ccc5b62af0f6a7.zip | |
fuse: set FR_PENDING atomically in fuse_resend()
When fuse_resend() moves the requests from processing lists to pending
list, it uses __set_bit() to set FR_PENDING bit in req->flags.
Using __set_bit() is not safe, because other functions may update
req->flags concurrently (e.g., request_wait_answer() may call
set_bit(FR_INTERRUPTED, &flags)).
Fix it by using set_bit() instead.
Fixes: 760eac73f9f6 ("fuse: Introduce a new notification type for resend pending requests")
Signed-off-by: Hou Tao <houtao1@huawei.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs/fuse')
| -rw-r--r-- | fs/fuse/dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 3ec8bb5e68ff..8eb2ce7c0b01 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -1813,7 +1813,7 @@ static void fuse_resend(struct fuse_conn *fc) spin_unlock(&fc->lock); list_for_each_entry_safe(req, next, &to_queue, list) { - __set_bit(FR_PENDING, &req->flags); + set_bit(FR_PENDING, &req->flags); /* mark the request as resend request */ req->in.h.unique |= FUSE_UNIQUE_RESEND; } |