diff options
| author | Steven Whitehouse <swhiteho@redhat.com> | 2009-04-30 14:52:58 +0100 |
|---|---|---|
| committer | Steven Whitehouse <swhiteho@redhat.com> | 2009-05-09 15:15:17 +0100 |
| commit | 0c7a531a200480c7bc447260376973d830da9069 (patch) | |
| tree | 778c5b97c869212f80bf94bd66ed04637e72e31d /fs/gfs2/glock.c | |
| parent | 091bf7624d1c90cec9e578a18529f615213ff847 (diff) | |
| download | linux-0c7a531a200480c7bc447260376973d830da9069.tar.gz linux-0c7a531a200480c7bc447260376973d830da9069.tar.bz2 linux-0c7a531a200480c7bc447260376973d830da9069.zip | |
GFS2: Fix glock ref counting bug
Depending on the ordering of events as we go around the
glock shrinker loop, it is possible to drop the ref count
of a glock incorrectly. It doesn't happen very often. This
patch corrects the got_ref variable, fixing the problem.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2/glock.c')
| -rw-r--r-- | fs/gfs2/glock.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 1afd9f26bcb1..ff4981090489 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -1304,6 +1304,7 @@ static int gfs2_shrink_glock_memory(int nr, gfp_t gfp_mask) nr--; if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0) gfs2_glock_put(gl); + got_ref = 0; } spin_lock(&lru_lock); if (may_demote) |