summaryrefslogtreecommitdiffstats
path: root/fs/gfs2/rgrp.c
diff options
context:
space:
mode:
authorWendy Cheng <wcheng@redhat.com>2007-06-27 17:07:08 -0400
committerSteven Whitehouse <swhiteho@redhat.com>2007-07-09 08:24:08 +0100
commitbb9bcf061660661c57ddcf31337529f82414b937 (patch)
tree0876874e5252c4939b8e7bbd62a22a6eb4ad1abf /fs/gfs2/rgrp.c
parentf4fadb23ca49abd2f1387a0b7e78b385ebc760ce (diff)
downloadlinux-bb9bcf061660661c57ddcf31337529f82414b937.tar.gz
linux-bb9bcf061660661c57ddcf31337529f82414b937.tar.bz2
linux-bb9bcf061660661c57ddcf31337529f82414b937.zip
[GFS2] Obtaining no_formal_ino from directory entry
GFS2 lookup code doesn't ask for inode shared glock. This implies during in-memory inode creation for existing file, GFS2 will not disk-read in the inode contents. This leaves no_formal_ino un-initialized during lookup time. The un-initialized no_formal_ino is subsequently encoded into file handle. Clients will get ESTALE error whenever it tries to access these files. Signed-off-by: S. Wendy Cheng <wcheng@redhat.com> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2/rgrp.c')
-rw-r--r--fs/gfs2/rgrp.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 36c523d487a7..7fb74484af63 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -860,18 +860,19 @@ static struct inode *try_rgrp_unlink(struct gfs2_rgrpd *rgd, u64 *last_unlinked)
{
struct inode *inode;
u32 goal = 0;
- u64 ino;
+ u64 no_addr;
for(;;) {
goal = rgblk_search(rgd, goal, GFS2_BLKST_UNLINKED,
GFS2_BLKST_UNLINKED);
if (goal == 0)
return 0;
- ino = goal + rgd->rd_data0;
- if (ino <= *last_unlinked)
+ no_addr = goal + rgd->rd_data0;
+ if (no_addr <= *last_unlinked)
continue;
- *last_unlinked = ino;
- inode = gfs2_inode_lookup(rgd->rd_sbd->sd_vfs, ino, DT_UNKNOWN);
+ *last_unlinked = no_addr;
+ inode = gfs2_inode_lookup(rgd->rd_sbd->sd_vfs, DT_UNKNOWN,
+ no_addr, 0);
if (!IS_ERR(inode))
return inode;
}