diff options
| author | Maxim <maxim.patlasov@gmail.com> | 2011-03-14 13:19:21 +0000 |
|---|---|---|
| committer | Steven Whitehouse <swhiteho@redhat.com> | 2011-03-14 13:19:21 +0000 |
| commit | 6c474f7bc1ef70bc05ce486e7e7e524124122de8 (patch) | |
| tree | c052a112e8719fdc8e72cf857be3ceaf183a6ac5 /fs/gfs2 | |
| parent | c618e87a5fd02aaad006c12d5a80a231dfa39250 (diff) | |
| download | linux-6c474f7bc1ef70bc05ce486e7e7e524124122de8.tar.gz linux-6c474f7bc1ef70bc05ce486e7e7e524124122de8.tar.bz2 linux-6c474f7bc1ef70bc05ce486e7e7e524124122de8.zip | |
GFS2: Adding missing unlock_page()
gfs2_write_begin() calls grab_cache_page_write_begin() that returns *locked*
page. Correspondent error-handling path lacks for unlock_page() call:
> out:
> if (error == 0)
> return 0;
>
> page_cache_release(page);
The whole system hangs if gfs2_unstuff_dinode() called from gfs2_write_begin()
failed for some reason.
Reported-by: Maxim <maxim.patlasov@gmail.com>
Signed-off-by: Maxim <maxim.patlasov@gmail.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2')
| -rw-r--r-- | fs/gfs2/aops.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index 4f36f8832b9b..aad77e4f61b5 100644 --- a/fs/gfs2/aops.c +++ b/fs/gfs2/aops.c @@ -695,6 +695,7 @@ out: if (error == 0) return 0; + unlock_page(page); page_cache_release(page); gfs2_trans_end(sdp); |