diff options
| author | Fabian Frederick <fabf@skynet.be> | 2015-04-16 12:47:01 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-04-17 09:04:05 -0400 |
| commit | 5e61473ea9f1ed6537ffaf6bf1cb60655f0d1b2c (patch) | |
| tree | 4ee3f0645b0a060a78945e8ce214c75f31fffa22 /fs/hfsplus/xattr_security.c | |
| parent | a3cef4cd6886c755d2148739699751900b51a365 (diff) | |
| download | linux-5e61473ea9f1ed6537ffaf6bf1cb60655f0d1b2c.tar.gz linux-5e61473ea9f1ed6537ffaf6bf1cb60655f0d1b2c.tar.bz2 linux-5e61473ea9f1ed6537ffaf6bf1cb60655f0d1b2c.zip | |
fs/hfsplus: move xattr_name allocation in hfsplus_setxattr()
security/trusted/user/osx setxattr did the same
xattr_name initialization. Move that operation in hfsplus_setxattr().
Tested with security/trusted/user getfattr/setfattr
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/hfsplus/xattr_security.c')
| -rw-r--r-- | fs/hfsplus/xattr_security.c | 19 |
1 files changed, 3 insertions, 16 deletions
diff --git a/fs/hfsplus/xattr_security.c b/fs/hfsplus/xattr_security.c index e67d52889448..aacff00a9ff9 100644 --- a/fs/hfsplus/xattr_security.c +++ b/fs/hfsplus/xattr_security.c @@ -24,22 +24,9 @@ static int hfsplus_security_getxattr(struct dentry *dentry, const char *name, static int hfsplus_security_setxattr(struct dentry *dentry, const char *name, const void *buffer, size_t size, int flags, int type) { - char *xattr_name; - int res; - - if (!strcmp(name, "")) - return -EINVAL; - - xattr_name = kmalloc(NLS_MAX_CHARSET_SIZE * HFSPLUS_ATTR_MAX_STRLEN + 1, - GFP_KERNEL); - if (!xattr_name) - return -ENOMEM; - strcpy(xattr_name, XATTR_SECURITY_PREFIX); - strcpy(xattr_name + XATTR_SECURITY_PREFIX_LEN, name); - - res = hfsplus_setxattr(dentry, xattr_name, buffer, size, flags); - kfree(xattr_name); - return res; + return hfsplus_setxattr(dentry, name, buffer, size, flags, + XATTR_SECURITY_PREFIX, + XATTR_SECURITY_PREFIX_LEN); } static size_t hfsplus_security_listxattr(struct dentry *dentry, char *list, |