diff options
| author | Dylan Yudaken <dylany@fb.com> | 2022-06-30 06:20:06 -0700 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-06-30 11:34:41 -0600 |
| commit | 09007af2b627f0f195c6c53c4829b285cc3990ec (patch) | |
| tree | 3546a6c5ce9a20d1a6170e406d990b67e330e849 /fs/io_uring.c | |
| parent | 29c1ac230e6056b26846c66881802b581a78ad72 (diff) | |
| download | linux-09007af2b627f0f195c6c53c4829b285cc3990ec.tar.gz linux-09007af2b627f0f195c6c53c4829b285cc3990ec.tar.bz2 linux-09007af2b627f0f195c6c53c4829b285cc3990ec.zip | |
io_uring: fix provided buffer import
io_import_iovec uses the s pointer, but this was changed immediately
after the iovec was re-imported and so it was imported into the wrong
place.
Change the ordering.
Fixes: 2be2eb02e2f5 ("io_uring: ensure reads re-import for selected buffers")
Signed-off-by: Dylan Yudaken <dylany@fb.com>
Link: https://lore.kernel.org/r/20220630132006.2825668-1-dylany@fb.com
[axboe: ensure we don't half-import as well]
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/io_uring.c')
| -rw-r--r-- | fs/io_uring.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/io_uring.c b/fs/io_uring.c index aeb042ba5cc5..0d491ad15b66 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -4318,18 +4318,19 @@ static int io_read(struct io_kiocb *req, unsigned int issue_flags) if (unlikely(ret < 0)) return ret; } else { + rw = req->async_data; + s = &rw->s; + /* * Safe and required to re-import if we're using provided * buffers, as we dropped the selected one before retry. */ - if (req->flags & REQ_F_BUFFER_SELECT) { + if (io_do_buffer_select(req)) { ret = io_import_iovec(READ, req, &iovec, s, issue_flags); if (unlikely(ret < 0)) return ret; } - rw = req->async_data; - s = &rw->s; /* * We come here from an earlier attempt, restore our state to * match in case it doesn't. It's cheap enough that we don't |