diff options
| author | Evgeniy Dushistov <dushistov@mail.ru> | 2006-06-05 08:21:03 -0500 |
|---|---|---|
| committer | Dave Kleikamp <shaggy@austin.ibm.com> | 2006-06-05 08:21:03 -0500 |
| commit | 48ce8b056c88920c8ac187781048f5dae33c81b9 (patch) | |
| tree | d03665af62302a252a5c60e7a920190ed93cbec8 /fs/jfs/jfs_txnmgr.c | |
| parent | 672c6108a51bf559d19595d9f8193dfd81f0f752 (diff) | |
| download | linux-48ce8b056c88920c8ac187781048f5dae33c81b9.tar.gz linux-48ce8b056c88920c8ac187781048f5dae33c81b9.tar.bz2 linux-48ce8b056c88920c8ac187781048f5dae33c81b9.zip | |
JFS: commit_mutex cleanups
I look at code, and see that
1)locks wasn't release in the opposite order in which they were taken
2)in jfs_rename we lock new_ip, and in "error path" we didn't unlock it
3)I see strange expression: "! !"
May be this worth to fix?
Signed-off-by: Evgeniy Dushistov <dushistov@mail.ru>
Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com>
Diffstat (limited to 'fs/jfs/jfs_txnmgr.c')
| -rw-r--r-- | fs/jfs/jfs_txnmgr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c index ac3d66948e8c..49618dd94f9a 100644 --- a/fs/jfs/jfs_txnmgr.c +++ b/fs/jfs/jfs_txnmgr.c @@ -2944,7 +2944,7 @@ int jfs_sync(void *arg) * Inode is being freed */ list_del_init(&jfs_ip->anon_inode_list); - } else if (! !mutex_trylock(&jfs_ip->commit_mutex)) { + } else if (mutex_trylock(&jfs_ip->commit_mutex)) { /* * inode will be removed from anonymous list * when it is committed |