diff options
author | NeilBrown <neilb@suse.com> | 2015-07-30 13:00:56 +1000 |
---|---|---|
committer | Trond Myklebust <trond.myklebust@primarydata.com> | 2015-08-12 14:42:23 -0400 |
commit | efcbc04e16dfa95fef76309f89710dd1d99a5453 (patch) | |
tree | 80c2687652c0925b21d5105c692a90d2dc26d73c /fs/nfs/callback.c | |
parent | 24a9a9610ce3ba36fd87c1d2f2c9106de6b7e832 (diff) | |
download | linux-efcbc04e16dfa95fef76309f89710dd1d99a5453.tar.gz linux-efcbc04e16dfa95fef76309f89710dd1d99a5453.tar.bz2 linux-efcbc04e16dfa95fef76309f89710dd1d99a5453.zip |
NFSv4: don't set SETATTR for O_RDONLY|O_EXCL
It is unusual to combine the open flags O_RDONLY and O_EXCL, but
it appears that libre-office does just that.
[pid 3250] stat("/home/USER/.config", {st_mode=S_IFDIR|0700, st_size=8192, ...}) = 0
[pid 3250] open("/home/USER/.config/libreoffice/4-suse/user/extensions/buildid", O_RDONLY|O_EXCL <unfinished ...>
NFSv4 takes O_EXCL as a sign that a setattr command should be sent,
probably to reset the timestamps.
When it was an O_RDONLY open, the SETATTR command does not
identify any actual attributes to change.
If no delegation was provided to the open, the SETATTR uses the
all-zeros stateid and the request is accepted (at least by the
Linux NFS server - no harm, no foul).
If a read-delegation was provided, this is used in the SETATTR
request, and a Netapp filer will justifiably claim
NFS4ERR_BAD_STATEID, which the Linux client takes as a sign
to retry - indefinitely.
So only treat O_EXCL specially if O_CREAT was also given.
Signed-off-by: NeilBrown <neilb@suse.com>
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Diffstat (limited to 'fs/nfs/callback.c')
0 files changed, 0 insertions, 0 deletions