diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2020-10-01 18:59:44 -0400 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2020-10-02 09:37:42 -0400 |
| commit | 1841b9b61492e35234bdca8a5737a0e5df770f27 (patch) | |
| tree | bbf2665767867df7a1096b6703b0d55edaacfdf9 /fs/nfsd/xdr.h | |
| parent | 7cf8357043bb828444cd9f4296f595bdbf68fa87 (diff) | |
| download | linux-1841b9b61492e35234bdca8a5737a0e5df770f27.tar.gz linux-1841b9b61492e35234bdca8a5737a0e5df770f27.tar.bz2 linux-1841b9b61492e35234bdca8a5737a0e5df770f27.zip | |
NFSD: Fix .pc_release method for NFSv2
nfsd_release_fhandle() assumes that rqstp->rq_resp always points to
an nfsd_fhandle struct. In fact, no NFSv2 procedure uses struct
nfsd_fhandle as its response structure.
So far that has been "safe" to do because the res structs put the
resp->fh field at that same offset as struct nfsd_fhandle. I don't
think that's a guarantee, though, and there is certainly nothing
preventing a developer from altering the fields in those structures.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd/xdr.h')
| -rw-r--r-- | fs/nfsd/xdr.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/nfsd/xdr.h b/fs/nfsd/xdr.h index ea7cca3a64b7..3d3e16d48268 100644 --- a/fs/nfsd/xdr.h +++ b/fs/nfsd/xdr.h @@ -156,7 +156,9 @@ int nfssvc_encode_readdirres(struct svc_rqst *, __be32 *); int nfssvc_encode_entry(void *, const char *name, int namlen, loff_t offset, u64 ino, unsigned int); -void nfssvc_release_fhandle(struct svc_rqst *); +void nfssvc_release_attrstat(struct svc_rqst *rqstp); +void nfssvc_release_diropres(struct svc_rqst *rqstp); +void nfssvc_release_readres(struct svc_rqst *rqstp); /* Helper functions for NFSv2 ACL code */ __be32 *nfs2svc_encode_fattr(struct svc_rqst *rqstp, __be32 *p, struct svc_fh *fhp, struct kstat *stat); |