diff options
| author | Tao Ma <boyu.mt@taobao.com> | 2011-03-07 16:43:21 +0800 |
|---|---|---|
| committer | Tao Ma <boyu.mt@taobao.com> | 2011-03-07 16:43:21 +0800 |
| commit | c1e8d35ef5ffb393b94a192034b5e3541e005d75 (patch) | |
| tree | b9a7f089acd3408c2835a3dfd6aa7bb0407587b3 /fs/ocfs2/symlink.c | |
| parent | ef6b689b63b9f5227ccee6f16dd9ee3faf58a464 (diff) | |
| download | linux-c1e8d35ef5ffb393b94a192034b5e3541e005d75.tar.gz linux-c1e8d35ef5ffb393b94a192034b5e3541e005d75.tar.bz2 linux-c1e8d35ef5ffb393b94a192034b5e3541e005d75.zip | |
ocfs2: Remove EXIT from masklog.
mlog_exit is used to record the exit status of a function.
But because it is added in so many functions, if we enable it,
the system logs get filled up quickly and cause too much I/O.
So actually no one can open it for a production system or even
for a test.
This patch just try to remove it or change it. So:
1. if all the error paths already use mlog_errno, it is just removed.
Otherwise, it will be replaced by mlog_errno.
2. if it is used to print some return value, it is replaced with
mlog(0,...).
mlog_exit_ptr is changed to mlog(0.
All those mlog(0,...) will be replaced with trace events later.
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Diffstat (limited to 'fs/ocfs2/symlink.c')
| -rw-r--r-- | fs/ocfs2/symlink.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/ocfs2/symlink.c b/fs/ocfs2/symlink.c index 8a81688c57df..5485b19ec8f2 100644 --- a/fs/ocfs2/symlink.c +++ b/fs/ocfs2/symlink.c @@ -72,7 +72,6 @@ static char *ocfs2_fast_symlink_getlink(struct inode *inode, fe = (struct ocfs2_dinode *) (*bh)->b_data; link = (char *) fe->id2.i_symlink; bail: - mlog_exit(status); return link; } @@ -100,7 +99,8 @@ static int ocfs2_readlink(struct dentry *dentry, brelse(bh); out: - mlog_exit(ret); + if (ret < 0) + mlog_errno(ret); return ret; } @@ -136,7 +136,8 @@ bail: nd_set_link(nd, status ? ERR_PTR(status) : link); brelse(bh); - mlog_exit(status); + if (status) + mlog_errno(status); return NULL; } |