diff options
author | Martin Brandenburg <martin@omnibond.com> | 2017-11-07 15:01:40 -0500 |
---|---|---|
committer | Mike Marshall <hubcap@omnibond.com> | 2017-11-13 15:10:11 -0500 |
commit | a55f2d861585006f493e933ad32d65d71ba631fa (patch) | |
tree | b05e25bf891a97bd2406378e3a5d51027df848c0 /fs/orangefs/symlink.c | |
parent | 296200d3bb649f9646f60abe6e8ebb9fd8d20f4b (diff) | |
download | linux-a55f2d861585006f493e933ad32d65d71ba631fa.tar.gz linux-a55f2d861585006f493e933ad32d65d71ba631fa.tar.bz2 linux-a55f2d861585006f493e933ad32d65d71ba631fa.zip |
orangefs: stop setting atime on inode dirty
The previous code path was to mark the inode dirty, let
orangefs_inode_dirty set a flag in our private inode, then later during
inode release call orangefs_flush_inode which notices the flag and
writes the atime out.
The code path worked almost identically for mtime, ctime, and mode
except that those flags are set explicitly and not as side effects of
dirty.
Now orangefs_flush_inode is removed. Marking an inode dirty does not
imply an atime update. Any place where flags were set before is now
an explicit call to orangefs_inode_setattr. Since OrangeFS does not
utilize inode writeback, the attribute change should be written out
immediately.
Fixes generic/120.
In namei.c, there are several places where the directory mtime and ctime
are set, but only the mtime is sent to the server. These don't seem
right, but I've left them as is for now.
Signed-off-by: Martin Brandenburg <martin@omnibond.com>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
Diffstat (limited to 'fs/orangefs/symlink.c')
-rw-r--r-- | fs/orangefs/symlink.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/orangefs/symlink.c b/fs/orangefs/symlink.c index d856cdf91763..db107fe91ab3 100644 --- a/fs/orangefs/symlink.c +++ b/fs/orangefs/symlink.c @@ -15,4 +15,5 @@ const struct inode_operations orangefs_symlink_inode_operations = { .getattr = orangefs_getattr, .listxattr = orangefs_listxattr, .permission = orangefs_permission, + .update_time = orangefs_update_time, }; |