summaryrefslogtreecommitdiffstats
path: root/fs/pstore
diff options
context:
space:
mode:
authorAruna Balakrishnaiah <aruna@linux.vnet.ibm.com>2013-06-25 14:33:56 +0530
committerTony Luck <tony.luck@intel.com>2013-06-25 10:04:38 -0700
commitbf2883339a33b7544b92ea465b90c3de55082032 (patch)
treeade69be0d8eadfda272ef5c48eb38f448c8731c9 /fs/pstore
parent26446654584c096e23dbe5a9b3f641edf9190c9d (diff)
downloadlinux-bf2883339a33b7544b92ea465b90c3de55082032.tar.gz
linux-bf2883339a33b7544b92ea465b90c3de55082032.tar.bz2
linux-bf2883339a33b7544b92ea465b90c3de55082032.zip
pstore: Fail to unlink if a driver has not defined pstore_erase
pstore_erase is used to erase the record from the persistent store. So if a driver has not defined pstore_erase callback return -EPERM instead of unlinking a file as deleting the file without erasing its record in persistent store will give a wrong impression to customers. Signed-off-by: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com> Acked-by: Kees Cook <keescook@chromium.org> Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'fs/pstore')
-rw-r--r--fs/pstore/inode.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c
index e4bcb2cf055a..bfd95bf38005 100644
--- a/fs/pstore/inode.c
+++ b/fs/pstore/inode.c
@@ -178,6 +178,8 @@ static int pstore_unlink(struct inode *dir, struct dentry *dentry)
if (p->psi->erase)
p->psi->erase(p->type, p->id, p->count,
dentry->d_inode->i_ctime, p->psi);
+ else
+ return -EPERM;
return simple_unlink(dir, dentry);
}