summaryrefslogtreecommitdiffstats
path: root/fs/ubifs
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-04-08 00:22:03 +0100
committerRichard Weinberger <richard@nod.at>2017-05-08 20:48:41 +0200
commit6a258f7d0fbd9f5e93099018741a7e64dd3a4578 (patch)
treea504f827dd82ddf08eb6167afcec996bb05c084b /fs/ubifs
parent8a1435880f452430b41374d27ac4a33e7bd381ea (diff)
downloadlinux-6a258f7d0fbd9f5e93099018741a7e64dd3a4578.tar.gz
linux-6a258f7d0fbd9f5e93099018741a7e64dd3a4578.tar.bz2
linux-6a258f7d0fbd9f5e93099018741a7e64dd3a4578.zip
ubifs: Fix cut and paste error on sb type comparisons
The check for the bad node type of sb->type is checking sa->type and not sb-type. This looks like a cut and paste error. Fix this. Detected by PVS-Studio, warning: V581 Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'fs/ubifs')
-rw-r--r--fs/ubifs/debug.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index 718b749fa11a..7cd8a7b95299 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -2391,8 +2391,8 @@ int dbg_check_nondata_nodes_order(struct ubifs_info *c, struct list_head *head)
ubifs_dump_node(c, sa->node);
return -EINVAL;
}
- if (sa->type != UBIFS_INO_NODE && sa->type != UBIFS_DENT_NODE &&
- sa->type != UBIFS_XENT_NODE) {
+ if (sb->type != UBIFS_INO_NODE && sb->type != UBIFS_DENT_NODE &&
+ sb->type != UBIFS_XENT_NODE) {
ubifs_err(c, "bad node type %d", sb->type);
ubifs_dump_node(c, sb->node);
return -EINVAL;