summaryrefslogtreecommitdiffstats
path: root/fs/ubifs
diff options
context:
space:
mode:
authorWenwen Wang <wenwen@cs.uga.edu>2019-08-19 22:24:50 -0500
committerRichard Weinberger <richard@nod.at>2019-09-15 22:11:58 +0200
commit7992e00469c485f108a7f0da08be34b0fa441f79 (patch)
tree57d0538e97c1a1b1c4a8bf0eb98d90f94043af6f /fs/ubifs
parentce4d8b16e64d062f1c6271a0068dbbbba2dee620 (diff)
downloadlinux-7992e00469c485f108a7f0da08be34b0fa441f79.tar.gz
linux-7992e00469c485f108a7f0da08be34b0fa441f79.tar.bz2
linux-7992e00469c485f108a7f0da08be34b0fa441f79.zip
ubifs: Fix memory leak in __ubifs_node_verify_hmac error path
In __ubifs_node_verify_hmac(), 'hmac' is allocated through kmalloc(). However, it is not deallocated in the following execution if ubifs_node_calc_hmac() fails, leading to a memory leak bug. To fix this issue, free 'hmac' before returning the error. Fixes: 49525e5eecca ("ubifs: Add helper functions for authentication support") Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu> Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'fs/ubifs')
-rw-r--r--fs/ubifs/auth.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c
index d9af2de9084a..8cdbd53d780c 100644
--- a/fs/ubifs/auth.c
+++ b/fs/ubifs/auth.c
@@ -479,8 +479,10 @@ int __ubifs_node_verify_hmac(const struct ubifs_info *c, const void *node,
return -ENOMEM;
err = ubifs_node_calc_hmac(c, node, len, ofs_hmac, hmac);
- if (err)
+ if (err) {
+ kfree(hmac);
return err;
+ }
err = crypto_memneq(hmac, node + ofs_hmac, hmac_len);