diff options
author | David Chinner <dgc@sgi.com> | 2006-11-11 18:05:00 +1100 |
---|---|---|
committer | Tim Shimmin <tes@sgi.com> | 2006-11-11 18:05:00 +1100 |
commit | 4c60658e0f4e253cf275f12b7c76bf128515a774 (patch) | |
tree | 72d591ce30b7bcc8e08b20aa325ac4360921f028 /fs/xattr.c | |
parent | 7a18c386078eaf17ae54595f66c0d64d9c1cb29c (diff) | |
download | linux-4c60658e0f4e253cf275f12b7c76bf128515a774.tar.gz linux-4c60658e0f4e253cf275f12b7c76bf128515a774.tar.bz2 linux-4c60658e0f4e253cf275f12b7c76bf128515a774.zip |
[XFS] Prevent a deadlock when xfslogd unpins inodes.
The previous fixes for the use after free in xfs_iunpin left a nasty log
deadlock when xfslogd unpinned the inode and dropped the last reference to
the inode. the ->clear_inode() method can issue transactions, and if the
log was full, the transaction could push on the log and get stuck trying
to push the inode it was currently unpinning.
To fix this, we provide xfs_iunpin a guarantee that it will always have a
valid xfs_inode <-> linux inode link or a particular flag will be set on
the inode. We then use log forces during lookup to ensure transactions are
completed before we recycle the inode. This ensures that xfs_iunpin will
never use the linux inode after it is being freed, and any lookup on an
inode on the reclaim list will wait until it is safe to attach a new linux
inode to the xfs inode.
SGI-PV: 956832
SGI-Modid: xfs-linux-melb:xfs-kern:27359a
Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Shailendra Tripathi <stripathi@agami.com>
Signed-off-by: Takenori Nagano <t-nagano@ah.jp.nec.com>
Signed-off-by: Tim Shimmin <tes@sgi.com>
Diffstat (limited to 'fs/xattr.c')
0 files changed, 0 insertions, 0 deletions