diff options
| author | Christoph Hellwig <hch@infradead.org> | 2011-02-13 13:26:42 +0000 |
|---|---|---|
| committer | Alex Elder <aelder@sgi.com> | 2011-02-22 20:32:28 -0600 |
| commit | ec3ba85f4083d10e32fe58b46db02d78ef71f6b8 (patch) | |
| tree | bf8e3b41e913c80f24673b87fb390ce6903d82ac /fs/xfs/quota | |
| parent | 1050c71e2925ab0cb025e4c89e08b15529a1ee36 (diff) | |
| download | linux-ec3ba85f4083d10e32fe58b46db02d78ef71f6b8.tar.gz linux-ec3ba85f4083d10e32fe58b46db02d78ef71f6b8.tar.bz2 linux-ec3ba85f4083d10e32fe58b46db02d78ef71f6b8.zip | |
xfs: more sensible inode refcounting for ialloc
Currently we return iodes from xfs_ialloc with just a single reference held.
But we need two references, as one is dropped during transaction commit and
the second needs to be transfered to the VFS. Change xfs_ialloc to use
xfs_iget plus xfs_trans_ijoin_ref to grab two references to the inode,
and remove the now superflous IHOLD calls from all callers. This also
greatly simplifies the error handling in xfs_create and also allow to remove
xfs_trans_iget as no other callers are left.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
Diffstat (limited to 'fs/xfs/quota')
| -rw-r--r-- | fs/xfs/quota/xfs_qm.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/fs/xfs/quota/xfs_qm.c b/fs/xfs/quota/xfs_qm.c index 206a2815ced6..f517963aec07 100644 --- a/fs/xfs/quota/xfs_qm.c +++ b/fs/xfs/quota/xfs_qm.c @@ -1230,13 +1230,6 @@ xfs_qm_qino_alloc( } /* - * Keep an extra reference to this quota inode. This inode is - * locked exclusively and joined to the transaction already. - */ - ASSERT(xfs_isilocked(*ip, XFS_ILOCK_EXCL)); - IHOLD(*ip); - - /* * Make the changes in the superblock, and log those too. * sbfields arg may contain fields other than *QUOTINO; * VERSIONNUM for example. |