diff options
| author | Eric Biggers <ebiggers@google.com> | 2021-01-22 16:48:18 -0800 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2021-01-22 16:54:49 -0800 |
| commit | eaf92540a9189851672d33215a34f22ea8d30446 (patch) | |
| tree | 59db0ca88666f5be8169dc6aea061e01339c4211 /fs/xfs/xfs_file.c | |
| parent | 301519674699aa9b80a15b2b2165e08532b176e6 (diff) | |
| download | linux-eaf92540a9189851672d33215a34f22ea8d30446.tar.gz linux-eaf92540a9189851672d33215a34f22ea8d30446.tar.bz2 linux-eaf92540a9189851672d33215a34f22ea8d30446.zip | |
xfs: remove a stale comment from xfs_file_aio_write_checks()
The comment in xfs_file_aio_write_checks() about calling file_modified()
after dropping the ilock doesn't make sense, because the code that
unconditionally acquires and drops the ilock was removed by
commit 467f78992a07 ("xfs: reduce ilock hold times in
xfs_file_aio_write_checks").
Remove this outdated comment.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/xfs/xfs_file.c')
| -rw-r--r-- | fs/xfs/xfs_file.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index 5b0f93f73837..4927c6653f15 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -389,12 +389,6 @@ restart: } else spin_unlock(&ip->i_flags_lock); - /* - * Updating the timestamps will grab the ilock again from - * xfs_fs_dirty_inode, so we have to call it after dropping the - * lock above. Eventually we should look into a way to avoid - * the pointless lock roundtrip. - */ return file_modified(file); } |