diff options
| author | Christoph Hellwig <hch@infradead.org> | 2012-02-20 02:31:22 +0000 |
|---|---|---|
| committer | Ben Myers <bpm@sgi.com> | 2012-02-22 22:17:00 -0600 |
| commit | 5b03ff1b2444ddf7b8084b7505101e97257aff5a (patch) | |
| tree | 25f783fa62973601e40d6af29ccf44a51b35267a /fs/xfs/xfs_inode_item.c | |
| parent | 3af1de753b3caf9fa3762b4b1b85d833c121847e (diff) | |
| download | linux-5b03ff1b2444ddf7b8084b7505101e97257aff5a.tar.gz linux-5b03ff1b2444ddf7b8084b7505101e97257aff5a.tar.bz2 linux-5b03ff1b2444ddf7b8084b7505101e97257aff5a.zip | |
xfs: remove xfs_trans_unlocked_item
There is no reason to wake up log space waiters when unlocking inodes or
dquots, and the commit log has no explanation for this function either.
Given that we now have exact log space wakeups everywhere we can assume
the reason for this function was to paper over log space races in earlier
XFS versions.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_inode_item.c')
| -rw-r--r-- | fs/xfs/xfs_inode_item.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/fs/xfs/xfs_inode_item.c b/fs/xfs/xfs_inode_item.c index 91d71dcd4852..adc8a261b5d0 100644 --- a/fs/xfs/xfs_inode_item.c +++ b/fs/xfs/xfs_inode_item.c @@ -596,11 +596,7 @@ xfs_inode_item_trylock( /* Stale items should force out the iclog */ if (ip->i_flags & XFS_ISTALE) { xfs_ifunlock(ip); - /* - * we hold the AIL lock - notify the unlock routine of this - * so it doesn't try to get the lock again. - */ - xfs_iunlock(ip, XFS_ILOCK_SHARED|XFS_IUNLOCK_NONOTIFY); + xfs_iunlock(ip, XFS_ILOCK_SHARED); return XFS_ITEM_PINNED; } |