summaryrefslogtreecommitdiffstats
path: root/fs/xfs
diff options
context:
space:
mode:
authorDenis Efremov <yefremov.denis@gmail.com>2013-10-25 15:53:25 +0400
committerBen Myers <bpm@sgi.com>2013-10-30 15:53:14 -0500
commit5bf1f439c89d4653f8cc8f8aa303e0d6991aba4b (patch)
treeb332e43e4d76d1a100ddb658eab9e55d0433e3b9 /fs/xfs
parentad22c7a043c2cc6792820e6c5da699935933e87d (diff)
downloadlinux-5bf1f439c89d4653f8cc8f8aa303e0d6991aba4b.tar.gz
linux-5bf1f439c89d4653f8cc8f8aa303e0d6991aba4b.tar.bz2
linux-5bf1f439c89d4653f8cc8f8aa303e0d6991aba4b.zip
xfs:xfs_dir2_node.c: pointer use before check for null
ASSERT on args takes place after args dereference. This assertion is redundant since we are going to panic anyway. Found by Linux Driver Verification project (linuxtesting.org) - PVS-Studio analyzer. Signed-off-by: Denis Efremov <yefremov.denis@gmail.com> Reviewed-by: Ben Myers <bpm@sgi.com> Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs')
-rw-r--r--fs/xfs/xfs_dir2_node.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/xfs/xfs_dir2_node.c b/fs/xfs/xfs_dir2_node.c
index f90bf0690346..56369d4509d5 100644
--- a/fs/xfs/xfs_dir2_node.c
+++ b/fs/xfs/xfs_dir2_node.c
@@ -1327,7 +1327,6 @@ xfs_dir2_leafn_split(
args = state->args;
dp = args->dp;
mp = dp->i_mount;
- ASSERT(args != NULL);
ASSERT(oldblk->magic == XFS_DIR2_LEAFN_MAGIC);
error = xfs_da_grow_inode(args, &blkno);
if (error) {