diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2017-05-22 15:40:12 -0500 |
---|---|---|
committer | Eric W. Biederman <ebiederm@xmission.com> | 2017-05-23 07:40:44 -0500 |
commit | c70d9d809fdeecedb96972457ee45c49a232d97f (patch) | |
tree | d814992a6f46fdc1b9faac491aaa30744cb2ed57 /fs | |
parent | 3fd37226216620c1a468afa999739d5016fbc349 (diff) | |
download | linux-c70d9d809fdeecedb96972457ee45c49a232d97f.tar.gz linux-c70d9d809fdeecedb96972457ee45c49a232d97f.tar.bz2 linux-c70d9d809fdeecedb96972457ee45c49a232d97f.zip |
ptrace: Properly initialize ptracer_cred on fork
When I introduced ptracer_cred I failed to consider the weirdness of
fork where the task_struct copies the old value by default. This
winds up leaving ptracer_cred set even when a process forks and
the child process does not wind up being ptraced.
Because ptracer_cred is not set on non-ptraced processes whose
parents were ptraced this has broken the ability of the enlightenment
window manager to start setuid children.
Fix this by properly initializing ptracer_cred in ptrace_init_task
This must be done with a little bit of care to preserve the current value
of ptracer_cred when ptrace carries through fork. Re-reading the
ptracer_cred from the ptracing process at this point is inconsistent
with how PT_PTRACE_CAP has been maintained all of these years.
Tested-by: Takashi Iwai <tiwai@suse.de>
Fixes: 64b875f7ac8a ("ptrace: Capture the ptracer's creds not PT_PTRACE_CAP")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions