summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorRonnie Sahlberg <lsahlber@redhat.com>2019-01-23 16:20:38 +1000
committerSteve French <stfrench@microsoft.com>2019-01-24 14:52:06 -0600
commit2e5700bdde438ed708b36d8acd0398dc73cbf759 (patch)
tree1c37b59481136a7e680368223f0126d7cce08208 /fs
parent6a9cbdd1ceca1dc2359ddf082efe61b97c3e752b (diff)
downloadlinux-2e5700bdde438ed708b36d8acd0398dc73cbf759.tar.gz
linux-2e5700bdde438ed708b36d8acd0398dc73cbf759.tar.bz2
linux-2e5700bdde438ed708b36d8acd0398dc73cbf759.zip
smb3: add credits we receive from oplock/break PDUs
Otherwise we gradually leak credits leading to potential hung session. Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com> CC: Stable <stable@vger.kernel.org> Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com> Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/cifs/smb2misc.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/cifs/smb2misc.c b/fs/cifs/smb2misc.c
index 6a9c47541c53..7b8b58fb4d3f 100644
--- a/fs/cifs/smb2misc.c
+++ b/fs/cifs/smb2misc.c
@@ -648,6 +648,13 @@ smb2_is_valid_oplock_break(char *buffer, struct TCP_Server_Info *server)
if (rsp->sync_hdr.Command != SMB2_OPLOCK_BREAK)
return false;
+ if (rsp->sync_hdr.CreditRequest) {
+ spin_lock(&server->req_lock);
+ server->credits += le16_to_cpu(rsp->sync_hdr.CreditRequest);
+ spin_unlock(&server->req_lock);
+ wake_up(&server->request_q);
+ }
+
if (rsp->StructureSize !=
smb2_rsp_struct_sizes[SMB2_OPLOCK_BREAK_HE]) {
if (le16_to_cpu(rsp->StructureSize) == 44)