diff options
| author | Ronnie Sahlberg <lsahlber@redhat.com> | 2019-02-07 15:48:44 +1000 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2019-03-04 20:05:34 -0600 |
| commit | 2109464184919f81efd593b4008291448c522815 (patch) | |
| tree | 8bdaaac790b1a36a9bf35b1aaf283e85f119ecce /fs | |
| parent | eca004523811f816bcfca3046ab54e1278e0973b (diff) | |
| download | linux-2109464184919f81efd593b4008291448c522815.tar.gz linux-2109464184919f81efd593b4008291448c522815.tar.bz2 linux-2109464184919f81efd593b4008291448c522815.zip | |
cifs: return -ENODATA when deleting an xattr that does not exist
BUGZILLA: https://bugzilla.kernel.org/show_bug.cgi?id=202007
When deleting an xattr/EA:
SMB2/3 servers will return SUCCESS when clients delete non-existing EAs.
This means that we need to first QUERY the server and check if the EA
exists or not so that we can return -ENODATA correctly when this happens.
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/cifs/smb2ops.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index 6f96e2292856..991c2d40c0ef 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -940,6 +940,16 @@ smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon, resp_buftype[0] = resp_buftype[1] = resp_buftype[2] = CIFS_NO_BUFFER; memset(rsp_iov, 0, sizeof(rsp_iov)); + if (ses->server->ops->query_all_EAs) { + if (!ea_value) { + rc = ses->server->ops->query_all_EAs(xid, tcon, path, + ea_name, NULL, 0, + cifs_sb); + if (rc == -ENODATA) + goto sea_exit; + } + } + /* Open */ memset(&open_iov, 0, sizeof(open_iov)); rqst[0].rq_iov = open_iov; |