diff options
| author | Vivek Goyal <vgoyal@redhat.com> | 2017-11-27 10:12:44 -0500 |
|---|---|---|
| committer | Miklos Szeredi <mszeredi@redhat.com> | 2017-12-11 11:28:10 +0100 |
| commit | 08d8f8a5b094b66b29936e8751b4a818b8db1207 (patch) | |
| tree | 7d3caa52694037484bc97e72011eda2f6c37dd1a /fs | |
| parent | 438c84c2f0c794f75ab55ce65c505b01bfce4480 (diff) | |
| download | linux-08d8f8a5b094b66b29936e8751b4a818b8db1207.tar.gz linux-08d8f8a5b094b66b29936e8751b4a818b8db1207.tar.bz2 linux-08d8f8a5b094b66b29936e8751b4a818b8db1207.zip | |
ovl: Pass ovl_get_nlink() parameters in right order
Right now we seem to be passing index as "lowerdentry" and origin.dentry
as "upperdentry". IIUC, we should pass these parameters in reversed order
and this looks like a bug.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Acked-by: Amir Goldstein <amir73il@gmail.com>
Fixes: caf70cb2ba5d ("ovl: cleanup orphan index entries")
Cc: <stable@vger.kernel.org> #v4.13
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/overlayfs/namei.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c index 2a12dc2e9840..beb945e1963c 100644 --- a/fs/overlayfs/namei.c +++ b/fs/overlayfs/namei.c @@ -435,7 +435,7 @@ int ovl_verify_index(struct dentry *index, struct ovl_path *lower, /* Check if index is orphan and don't warn before cleaning it */ if (d_inode(index)->i_nlink == 1 && - ovl_get_nlink(index, origin.dentry, 0) == 0) + ovl_get_nlink(origin.dentry, index, 0) == 0) err = -ENOENT; dput(origin.dentry); |