diff options
| author | Tejun Heo <tj@kernel.org> | 2015-03-24 14:14:18 -0400 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2015-03-24 14:14:18 -0400 |
| commit | 3a02824396c1df1db422d067b0fdcac724f44dd6 (patch) | |
| tree | 94194de9c52ec3aac023d68b548943150d151731 /include/linux/libata.h | |
| parent | db7a657f3c2de202e8d648b03bc25bcd9a4de1d8 (diff) | |
| download | linux-3a02824396c1df1db422d067b0fdcac724f44dd6.tar.gz linux-3a02824396c1df1db422d067b0fdcac724f44dd6.tar.bz2 linux-3a02824396c1df1db422d067b0fdcac724f44dd6.zip | |
libata: remove ATA_FLAG_LOWTAG
sata_sil24 for some reason pukes when tags are allocated round-robin
which helps tag ordered controllers. To work around the issue,
72dd299d5039 ("libata: allow sata_sil24 to opt-out of tag ordered
submission") introduced ATA_FLAG_LOWTAG which tells libata tag
allocation to do lowest-first.
However, with the recent switch to blk-mq tag allocation, the liata
tag allocation code path is no longer used and the workaround is now
implemented in the block layer and selected by setting
scsi_host_template->tag_alloc_policy to BLK_TAG_ALLOC_FIFO. See
9269e23496dd ("libata: make sata_sil24 use fifo tag allocator").
This leaves ATA_FLAG_LOWTAG withoout any actual user. Remove it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Shaohua Li <shli@fb.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'include/linux/libata.h')
| -rw-r--r-- | include/linux/libata.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/libata.h b/include/linux/libata.h index fc03efa64ffe..ebe132a4873c 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -231,7 +231,6 @@ enum { ATA_FLAG_SW_ACTIVITY = (1 << 22), /* driver supports sw activity * led */ ATA_FLAG_NO_DIPM = (1 << 23), /* host not happy with DIPM */ - ATA_FLAG_LOWTAG = (1 << 24), /* host wants lowest available tag */ /* bits 24:31 of ap->flags are reserved for LLD specific flags */ |