summaryrefslogtreecommitdiffstats
path: root/include/linux/reset.h
diff options
context:
space:
mode:
authorSerge Semin <Sergey.Semin@baikalelectronics.ru>2022-06-24 17:18:45 +0300
committerPhilipp Zabel <p.zabel@pengutronix.de>2022-06-29 15:56:20 +0200
commita57f68ddc8865d59a19783080cc52fb4a11dc209 (patch)
tree741be22c8e8ab3d8d2db60a74e529f73e5a03f02 /include/linux/reset.h
parenta5bdaae7ae596686b83a8a5038ee6d9afeb24531 (diff)
downloadlinux-a57f68ddc8865d59a19783080cc52fb4a11dc209.tar.gz
linux-a57f68ddc8865d59a19783080cc52fb4a11dc209.tar.bz2
linux-a57f68ddc8865d59a19783080cc52fb4a11dc209.zip
reset: Fix devm bulk optional exclusive control getter
Most likely due to copy-paste mistake the device managed version of the denoted reset control getter has been implemented with invalid semantic, which can be immediately spotted by having "WARN_ON(shared && acquired)" warning in the system log as soon as the method is called. Anyway let's fix it by altering the boolean arguments passed to the __devm_reset_control_bulk_get() method from - shared = true, optional = false, acquired = true to + shared = false, optional = true, acquired = true That's what they were supposed to be in the first place (see the non-devm version of the same method: reset_control_bulk_get_optional_exclusive()). Fixes: 48d71395896d ("reset: Add reset_control_bulk API") Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> Link: https://lore.kernel.org/r/20220624141853.7417-2-Sergey.Semin@baikalelectronics.ru
Diffstat (limited to 'include/linux/reset.h')
-rw-r--r--include/linux/reset.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/reset.h b/include/linux/reset.h
index 8a21b5756c3e..514ddf003efc 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -731,7 +731,7 @@ static inline int __must_check
devm_reset_control_bulk_get_optional_exclusive(struct device *dev, int num_rstcs,
struct reset_control_bulk_data *rstcs)
{
- return __devm_reset_control_bulk_get(dev, num_rstcs, rstcs, true, false, true);
+ return __devm_reset_control_bulk_get(dev, num_rstcs, rstcs, false, true, true);
}
/**