summaryrefslogtreecommitdiffstats
path: root/include/scsi
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2019-04-12 09:33:01 +0100
committerMartin K. Petersen <martin.petersen@oracle.com>2019-04-12 20:05:31 -0400
commitea63e60f7a3e9fd494b46d1c68d3d26b068c2d63 (patch)
tree08bedb940f787b3024c988b7d69e3953e0a2cae7 /include/scsi
parentc8538b0b9ed65eb22849217fd397d614a42216e7 (diff)
downloadlinux-ea63e60f7a3e9fd494b46d1c68d3d26b068c2d63.tar.gz
linux-ea63e60f7a3e9fd494b46d1c68d3d26b068c2d63.tar.bz2
linux-ea63e60f7a3e9fd494b46d1c68d3d26b068c2d63.zip
scsi: cxgbi: remove redundant __kfree_skb call on skb and free cst->atid
The error return path via label rel_resource checks for a non-null skb before free'ing it. However, skb is always null at this exit path, so the null check and the free are redundant and can be removed. Removing this allows the original goto's to rel_resource to be cleaned up; the first can be replaced by a return of -EINVAL, the second can be replaced by a more appropriate -ENOMEM return and fix a memory leak by freeing csk->atid. Addresses-Coverity: ("Logically Dead Code") Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'include/scsi')
0 files changed, 0 insertions, 0 deletions