diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2021-03-26 13:22:21 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-03-26 15:09:45 -0700 |
| commit | ad1cd7856d870e5861ef80fbf3e4b0d68bb82a69 (patch) | |
| tree | 7b33d793d9fa5e0c3eb7f0370406da2e08717b7f /include/uapi/linux/ethtool.h | |
| parent | f59798b8f683ec16e724d0a0a43c75cfa4822ec1 (diff) | |
| download | linux-ad1cd7856d870e5861ef80fbf3e4b0d68bb82a69.tar.gz linux-ad1cd7856d870e5861ef80fbf3e4b0d68bb82a69.tar.bz2 linux-ad1cd7856d870e5861ef80fbf3e4b0d68bb82a69.zip | |
ethtool: fec: add note about reuse of reserved
struct ethtool_fecparam::reserved can't be used in SET, because
ethtool user space doesn't zero-initialize the structure.
Make this clear.
Suggested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/uapi/linux/ethtool.h')
| -rw-r--r-- | include/uapi/linux/ethtool.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index f6ef7d42c7a1..9a47c3efd8ca 100644 --- a/include/uapi/linux/ethtool.h +++ b/include/uapi/linux/ethtool.h @@ -1382,6 +1382,10 @@ struct ethtool_per_queue_op { * @fec: Bitmask of configured FEC modes. * @reserved: Reserved for future extensions, ignore on GET, write 0 for SET. * + * Note that @reserved was never validated on input and ethtool user space + * left it uninitialized when calling SET. Hence going forward it can only be + * used to return a value to userspace with GET. + * * FEC modes supported by the device can be read via %ETHTOOL_GLINKSETTINGS. * FEC settings are configured by link autonegotiation whenever it's enabled. * With autoneg on %ETHTOOL_GFECPARAM can be used to read the current mode. |