diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2009-07-21 11:09:39 +0200 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2009-07-21 14:35:07 +0200 |
| commit | 591d2fb02ea80472d846c0b8507007806bdd69cc (patch) | |
| tree | c7962a95a47bbdf664f15a504eff24c351f33613 /include | |
| parent | aea1f7964ae6cba5eb419a958956deb9016b3341 (diff) | |
| download | linux-591d2fb02ea80472d846c0b8507007806bdd69cc.tar.gz linux-591d2fb02ea80472d846c0b8507007806bdd69cc.tar.bz2 linux-591d2fb02ea80472d846c0b8507007806bdd69cc.zip | |
genirq: Delegate irq affinity setting to the irq thread
irq_set_thread_affinity() calls set_cpus_allowed_ptr() which might
sleep, but irq_set_thread_affinity() is called with desc->lock held
and can be called from hard interrupt context as well. The code has
another bug as it does not hold a ref on the task struct as required
by set_cpus_allowed_ptr().
Just set the IRQTF_AFFINITY bit in action->thread_flags. The next time
the thread runs it migrates itself. Solves all of the above problems
nicely.
Add kerneldoc to irq_set_thread_affinity() while at it.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
LKML-Reference: <new-submission>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/interrupt.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h index 2721f07e9354..88b056ac5629 100644 --- a/include/linux/interrupt.h +++ b/include/linux/interrupt.h @@ -64,11 +64,13 @@ * IRQTF_RUNTHREAD - signals that the interrupt handler thread should run * IRQTF_DIED - handler thread died * IRQTF_WARNED - warning "IRQ_WAKE_THREAD w/o thread_fn" has been printed + * IRQTF_AFFINITY - irq thread is requested to adjust affinity */ enum { IRQTF_RUNTHREAD, IRQTF_DIED, IRQTF_WARNED, + IRQTF_AFFINITY, }; typedef irqreturn_t (*irq_handler_t)(int, void *); |