summaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2010-05-31 12:19:37 -0700
committerRusty Russell <rusty@rustcorp.com.au>2010-06-05 11:17:35 +0930
commit2c02dfe7fe3fba97a5665d329d039d2415ea5607 (patch)
tree7f50644bbfcc119cb85e21642a76eabfaf77b8ad /include
parentad8456361fa19068cf49b50a4f98e41b73c08e76 (diff)
downloadlinux-2c02dfe7fe3fba97a5665d329d039d2415ea5607.tar.gz
linux-2c02dfe7fe3fba97a5665d329d039d2415ea5607.tar.bz2
linux-2c02dfe7fe3fba97a5665d329d039d2415ea5607.zip
module: Make the 'usage' lists be two-way
When adding a module that depends on another one, we used to create a one-way list of "modules_which_use_me", so that module unloading could see who needs a module. It's actually quite simple to make that list go both ways: so that we not only can see "who uses me", but also see a list of modules that are "used by me". In fact, we always wanted that list in "module_unload_free()": when we unload a module, we want to also release all the other modules that are used by that module. But because we didn't have that list, we used to first iterate over all modules, and then iterate over each "used by me" list of that module. By making the list two-way, we simplify module_unload_free(), and it allows for some trivial fixes later too. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (cleaned & rebased)
Diffstat (limited to 'include')
-rw-r--r--include/linux/module.h4
1 files changed, 3 insertions, 1 deletions
diff --git a/include/linux/module.h b/include/linux/module.h
index 6914fcad4673..680db9e2ac36 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -359,7 +359,9 @@ struct module
#ifdef CONFIG_MODULE_UNLOAD
/* What modules depend on me? */
- struct list_head modules_which_use_me;
+ struct list_head source_list;
+ /* What modules do I depend on? */
+ struct list_head target_list;
/* Who is waiting for us to be unloaded */
struct task_struct *waiter;