summaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorDaniel Borkmann <daniel@iogearbox.net>2017-02-02 17:09:54 +0100
committerDavid S. Miller <davem@davemloft.net>2017-02-03 15:50:18 -0500
commit3898fac1f488c76e0eef5b5267b4ba8112a82ac4 (patch)
treefc6ee165a3338409580a8784111f53c10b22c6d5 /include
parentf38c5ad79f1eb5569843ea24ac7f4cabccc3c657 (diff)
downloadlinux-3898fac1f488c76e0eef5b5267b4ba8112a82ac4.tar.gz
linux-3898fac1f488c76e0eef5b5267b4ba8112a82ac4.tar.bz2
linux-3898fac1f488c76e0eef5b5267b4ba8112a82ac4.zip
trace: rename trace_print_hex_seq arg and add kdoc
Steven suggested to improve trace_print_hex_seq() a bit after commit 2acae0d5b0f7 ("trace: add variant without spacing in trace_print_hex_seq") in two ways: i) by adding a kdoc comment for the helper function itself and ii) by renaming 'spacing' argument into 'concatenate' to better denote that we don't add spaces between each hex bytes. Suggested-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
-rw-r--r--include/linux/trace_events.h2
-rw-r--r--include/trace/trace_events.h4
2 files changed, 3 insertions, 3 deletions
diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
index cfa475a0e9ca..0f165507495c 100644
--- a/include/linux/trace_events.h
+++ b/include/linux/trace_events.h
@@ -34,7 +34,7 @@ const char *trace_print_bitmask_seq(struct trace_seq *p, void *bitmask_ptr,
const char *trace_print_hex_seq(struct trace_seq *p,
const unsigned char *buf, int len,
- bool spacing);
+ bool concatenate);
const char *trace_print_array_seq(struct trace_seq *p,
const void *buf, int count,
diff --git a/include/trace/trace_events.h b/include/trace/trace_events.h
index 9f684629c3cf..5c06f4af8323 100644
--- a/include/trace/trace_events.h
+++ b/include/trace/trace_events.h
@@ -298,11 +298,11 @@ TRACE_MAKE_SYSTEM_STR();
#undef __print_hex
#define __print_hex(buf, buf_len) \
- trace_print_hex_seq(p, buf, buf_len, true)
+ trace_print_hex_seq(p, buf, buf_len, false)
#undef __print_hex_str
#define __print_hex_str(buf, buf_len) \
- trace_print_hex_seq(p, buf, buf_len, false)
+ trace_print_hex_seq(p, buf, buf_len, true)
#undef __print_array
#define __print_array(array, count, el_size) \