summaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorNicolas Dichtel <nicolas.dichtel@6wind.com>2017-06-08 10:37:45 +0200
committerDavid S. Miller <davem@davemloft.net>2017-06-08 15:57:09 -0400
commitdaa6630a310fe2ad90ce5f7d2d196cd0353ef4fa (patch)
tree29e10bd3ba2c42a9a2c190ba3c11c021c56a1b48 /include
parent0db47e3d323411beeb6ea97f2c4d19395c91fd8b (diff)
downloadlinux-daa6630a310fe2ad90ce5f7d2d196cd0353ef4fa.tar.gz
linux-daa6630a310fe2ad90ce5f7d2d196cd0353ef4fa.tar.bz2
linux-daa6630a310fe2ad90ce5f7d2d196cd0353ef4fa.zip
openvswitch: warn about missing first netlink attribute
The first netlink attribute (value 0) must always be defined as none/unspec. Because we cannot change an existing UAPI, I add a comment to point the mistake and avoid to propagate it in a new ovs API in the future. Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
-rw-r--r--include/uapi/linux/openvswitch.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h
index 61b7d36dfe34..156ee4cab82e 100644
--- a/include/uapi/linux/openvswitch.h
+++ b/include/uapi/linux/openvswitch.h
@@ -343,6 +343,7 @@ enum ovs_key_attr {
#define OVS_KEY_ATTR_MAX (__OVS_KEY_ATTR_MAX - 1)
enum ovs_tunnel_key_attr {
+ /* OVS_TUNNEL_KEY_ATTR_NONE, standard nl API requires this attribute! */
OVS_TUNNEL_KEY_ATTR_ID, /* be64 Tunnel ID */
OVS_TUNNEL_KEY_ATTR_IPV4_SRC, /* be32 src IP address. */
OVS_TUNNEL_KEY_ATTR_IPV4_DST, /* be32 dst IP address. */