diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2015-09-17 18:19:34 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2017-06-20 11:27:01 -0300 |
| commit | d320695add65d8f909e4edbdcc8b66ae504854a6 (patch) | |
| tree | 6337a863b59d7a0002171716b542266467b737be /include | |
| parent | 76724b30f222067faf00874dc277f6c99d03d800 (diff) | |
| download | linux-d320695add65d8f909e4edbdcc8b66ae504854a6.tar.gz linux-d320695add65d8f909e4edbdcc8b66ae504854a6.tar.bz2 linux-d320695add65d8f909e4edbdcc8b66ae504854a6.zip | |
[media] dvb: don't use 'time_t' in event ioctl
'struct video_event' is used for the VIDEO_GET_EVENT ioctl, implemented
by drivers/media/pci/ivtv/ivtv-ioctl.c and
drivers/media/pci/ttpci/av7110_av.c. The structure contains a 'time_t',
which will be redefined in the future to be 64-bit wide, causing an
incompatible ABI change for this ioctl.
As it turns out, neither of the drivers currently sets the timestamp
field, and it is presumably useless anyway because of the limited
resolutions (no sub-second times). This means we can simply change
the structure definition to use a 'long' instead of 'time_t' and
remain compatible with all existing user space binaries when time_t
gets changed.
If anybody ever starts using this field, they have to make sure not
to use 1970 based seconds in there, as those overflow in 2038.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/uapi/linux/dvb/video.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/uapi/linux/dvb/video.h b/include/uapi/linux/dvb/video.h index 260f033a5b54..c83d40b8a8a4 100644 --- a/include/uapi/linux/dvb/video.h +++ b/include/uapi/linux/dvb/video.h @@ -134,7 +134,8 @@ struct video_event { #define VIDEO_EVENT_FRAME_RATE_CHANGED 2 #define VIDEO_EVENT_DECODER_STOPPED 3 #define VIDEO_EVENT_VSYNC 4 - __kernel_time_t timestamp; + /* unused, make sure to use atomic time for y2038 if it ever gets used */ + long timestamp; union { video_size_t size; unsigned int frame_rate; /* in frames per 1000sec */ |