diff options
| author | Keith Busch <kbusch@kernel.org> | 2023-11-20 14:18:31 -0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2023-11-20 15:21:38 -0700 |
| commit | d6fef34ee4d102be448146f24caf96d7b4a05401 (patch) | |
| tree | 3745518ea8f7e860b7a3fbc6178a9ee2c063aac7 /io_uring | |
| parent | 8479063f1fbee201a8739130e816cc331b675838 (diff) | |
| download | linux-d6fef34ee4d102be448146f24caf96d7b4a05401.tar.gz linux-d6fef34ee4d102be448146f24caf96d7b4a05401.tar.bz2 linux-d6fef34ee4d102be448146f24caf96d7b4a05401.zip | |
io_uring: fix off-by one bvec index
If the offset equals the bv_len of the first registered bvec, then the
request does not include any of that first bvec. Skip it so that drivers
don't have to deal with a zero length bvec, which was observed to break
NVMe's PRP list creation.
Cc: stable@vger.kernel.org
Fixes: bd11b3a391e3 ("io_uring: don't use iov_iter_advance() for fixed buffers")
Signed-off-by: Keith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20231120221831.2646460-1-kbusch@meta.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'io_uring')
| -rw-r--r-- | io_uring/rsrc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c index 7034be555334..f521c5965a93 100644 --- a/io_uring/rsrc.c +++ b/io_uring/rsrc.c @@ -1258,7 +1258,7 @@ int io_import_fixed(int ddir, struct iov_iter *iter, */ const struct bio_vec *bvec = imu->bvec; - if (offset <= bvec->bv_len) { + if (offset < bvec->bv_len) { /* * Note, huge pages buffers consists of one large * bvec entry and should always go this way. The other |