diff options
| author | Maxin B John <maxin.john@gmail.com> | 2011-07-25 17:12:59 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-07-25 20:57:14 -0700 |
| commit | ae891a1b93bf62e9aaa116a7a71312375047fc9f (patch) | |
| tree | 83e821e818654da3e3443ecddd757665251db6e0 /kernel/irq/devres.c | |
| parent | 5190f0c030f46b3169205f34f6d9ef480fa39ef2 (diff) | |
| download | linux-ae891a1b93bf62e9aaa116a7a71312375047fc9f.tar.gz linux-ae891a1b93bf62e9aaa116a7a71312375047fc9f.tar.bz2 linux-ae891a1b93bf62e9aaa116a7a71312375047fc9f.zip | |
devres: fix possible use after free
devres uses the pointer value as key after it's freed, which is safe but
triggers spurious use-after-free warnings on some static analysis tools.
Rearrange code to avoid such warnings.
Signed-off-by: Maxin B. John <maxin.john@gmail.com>
Reviewed-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/irq/devres.c')
| -rw-r--r-- | kernel/irq/devres.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/irq/devres.c b/kernel/irq/devres.c index 1ef4ffcdfa55..bd8e788d71e0 100644 --- a/kernel/irq/devres.c +++ b/kernel/irq/devres.c @@ -87,8 +87,8 @@ void devm_free_irq(struct device *dev, unsigned int irq, void *dev_id) { struct irq_devres match_data = { irq, dev_id }; - free_irq(irq, dev_id); WARN_ON(devres_destroy(dev, devm_irq_release, devm_irq_match, &match_data)); + free_irq(irq, dev_id); } EXPORT_SYMBOL(devm_free_irq); |