diff options
| author | Paul E. McKenney <paulmck@kernel.org> | 2024-02-22 12:29:54 -0800 |
|---|---|---|
| committer | Boqun Feng <boqun.feng@gmail.com> | 2024-02-25 14:21:34 -0800 |
| commit | 30ef09635b9ed3ebca4f677495332a2e444a5cda (patch) | |
| tree | 766f658e1614fd2e0687858eb50522dcb0aba8cc /kernel/rcu/rcu.h | |
| parent | bfe93930ea1ea3c6c115a7d44af6e4fea609067e (diff) | |
| download | linux-30ef09635b9ed3ebca4f677495332a2e444a5cda.tar.gz linux-30ef09635b9ed3ebca4f677495332a2e444a5cda.tar.bz2 linux-30ef09635b9ed3ebca4f677495332a2e444a5cda.zip | |
rcu-tasks: Initialize callback lists at rcu_init() time
In order for RCU Tasks to reliably maintain per-CPU lists of exiting
tasks, those lists must be initialized before it is possible for tasks
to exit, especially given that the boot CPU is not necessarily CPU 0
(an example being, powerpc kexec() kernels). And at the time that
rcu_init_tasks_generic() is called, a task could potentially exit,
unconventional though that sort of thing might be.
This commit therefore moves the calls to cblist_init_generic() from
functions called from rcu_init_tasks_generic() to a new function named
tasks_cblist_init_generic() that is invoked from rcu_init().
This constituted a bug in a commit that never went to mainline, so
there is no need for any backporting to -stable.
Reported-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Diffstat (limited to 'kernel/rcu/rcu.h')
| -rw-r--r-- | kernel/rcu/rcu.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/kernel/rcu/rcu.h b/kernel/rcu/rcu.h index f94f65877f2b..ef63ea59c8b6 100644 --- a/kernel/rcu/rcu.h +++ b/kernel/rcu/rcu.h @@ -528,6 +528,12 @@ struct task_struct *get_rcu_tasks_gp_kthread(void); struct task_struct *get_rcu_tasks_rude_gp_kthread(void); #endif // # ifdef CONFIG_TASKS_RUDE_RCU +#ifdef CONFIG_TASKS_RCU_GENERIC +void tasks_cblist_init_generic(void); +#else /* #ifdef CONFIG_TASKS_RCU_GENERIC */ +static inline void tasks_cblist_init_generic(void) { } +#endif /* #else #ifdef CONFIG_TASKS_RCU_GENERIC */ + #define RCU_SCHEDULER_INACTIVE 0 #define RCU_SCHEDULER_INIT 1 #define RCU_SCHEDULER_RUNNING 2 |