diff options
| author | Peter Zijlstra <peterz@infradead.org> | 2013-07-26 23:48:42 +0200 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2013-07-30 22:14:37 +0200 |
| commit | bf0bd948d1682e3996adc093b43021ed391983e6 (patch) | |
| tree | 8a12aee445d19b290d42d15730a0d7b1972bd2b9 /kernel/sched | |
| parent | e69f61862ab833e9b8d3c15b6ce07fd69f3bfecc (diff) | |
| download | linux-bf0bd948d1682e3996adc093b43021ed391983e6.tar.gz linux-bf0bd948d1682e3996adc093b43021ed391983e6.tar.bz2 linux-bf0bd948d1682e3996adc093b43021ed391983e6.zip | |
sched: Ensure update_cfs_shares() is called for parents of continuously-running tasks
We typically update a task_group's shares within the dequeue/enqueue
path. However, continuously running tasks sharing a CPU are not
subject to these updates as they are only put/picked. Unfortunately,
when we reverted f269ae046 (in 17bc14b7), we lost the augmenting
periodic update that was supposed to account for this; resulting in a
potential loss of fairness.
To fix this, re-introduce the explicit update in
update_cfs_rq_blocked_load() [called via entity_tick()].
Reported-by: Max Hailperin <max@gustavus.edu>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Reviewed-by: Paul Turner <pjt@google.com>
Link: http://lkml.kernel.org/n/tip-9545m3apw5d93ubyrotrj31y@git.kernel.org
Cc: <stable@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/sched')
| -rw-r--r-- | kernel/sched/fair.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 98d135584b4b..06db94bf47a8 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2032,6 +2032,7 @@ entity_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr, int queued) */ update_entity_load_avg(curr, 1); update_cfs_rq_blocked_load(cfs_rq, 1); + update_cfs_shares(cfs_rq); #ifdef CONFIG_SCHED_HRTICK /* |