diff options
| author | Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-06 16:39:55 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-07-08 12:10:33 +0100 |
| commit | 2d3b559df3ed39258737789aae2ae7973d205bc1 (patch) | |
| tree | 08166f624f7b55cc747a52776ece600269ec1816 /kernel/sysctl.c | |
| parent | f613d86d014b6375a4085901de39406598121e35 (diff) | |
| download | linux-2d3b559df3ed39258737789aae2ae7973d205bc1.tar.gz linux-2d3b559df3ed39258737789aae2ae7973d205bc1.tar.bz2 linux-2d3b559df3ed39258737789aae2ae7973d205bc1.zip | |
sysctl: Fix data races in proc_douintvec_minmax().
A sysctl variable is accessed concurrently, and there is always a chance
of data-race. So, all readers and writers need some basic protection to
avoid load/store-tearing.
This patch changes proc_douintvec_minmax() to use READ_ONCE() and
WRITE_ONCE() internally to fix data-races on the sysctl side. For now,
proc_douintvec_minmax() itself is tolerant to a data-race, but we still
need to add annotations on the other subsystem's side.
Fixes: 61d9b56a8920 ("sysctl: add unsigned int range support")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'kernel/sysctl.c')
| -rw-r--r-- | kernel/sysctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 4d87832367f2..379721a03d41 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -923,7 +923,7 @@ static int do_proc_douintvec_minmax_conv(unsigned long *lvalp, (param->max && *param->max < tmp)) return -ERANGE; - *valp = tmp; + WRITE_ONCE(*valp, tmp); } return 0; |