diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2013-11-13 21:01:57 +0100 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2013-11-19 14:59:50 +0100 |
commit | d689fe222a858c767cb8594faf280048e532b53f (patch) | |
tree | 2ddb3ee24ce9fd2566a6fb9204ea9861a74a7404 /kernel/timer.c | |
parent | 801a76050bcf8d4e500eb8d048ff6265f37a61c8 (diff) | |
download | linux-d689fe222a858c767cb8594faf280048e532b53f.tar.gz linux-d689fe222a858c767cb8594faf280048e532b53f.tar.bz2 linux-d689fe222a858c767cb8594faf280048e532b53f.zip |
NOHZ: Check for nohz active instead of nohz enabled
RCU and the fine grained idle time accounting functions check
tick_nohz_enabled. But that variable is merily telling that NOHZ has
been enabled in the config and not been disabled on the command line.
But it does not tell anything about nohz being active. That's what all
this should check for.
Matthew reported, that the idle accounting on his old P1 machine
showed bogus values, when he enabled NOHZ in the config and did not
disable it on the kernel command line. The reason is that his machine
uses (refined) jiffies as a clocksource which explains why the "fine"
grained accounting went into lala land, because it depends on when the
system goes and leaves idle relative to the jiffies increment.
Provide a tick_nohz_active indicator and let RCU and the accounting
code use this instead of tick_nohz_enable.
Reported-and-tested-by: Matthew Whitehead <tedheadster@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: john.stultz@linaro.org
Cc: mwhitehe@redhat.com
Link: http://lkml.kernel.org/r/alpine.DEB.2.02.1311132052240.30673@ionos.tec.linutronix.de
Diffstat (limited to 'kernel/timer.c')
0 files changed, 0 insertions, 0 deletions