summaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorLi Zefan <lizf@cn.fujitsu.com>2009-04-11 15:52:35 +0800
committerIngo Molnar <mingo@elte.hu>2009-04-12 11:59:28 +0200
commitbcabd91c271e50eebc0cb9220ac92700332b452e (patch)
tree5513a154d06b4ad1737e6787feeab5d2573f2c43 /kernel
parent8433a40eb7f2c4883ad57f9900f63e4d59240eb7 (diff)
downloadlinux-bcabd91c271e50eebc0cb9220ac92700332b452e.tar.gz
linux-bcabd91c271e50eebc0cb9220ac92700332b452e.tar.bz2
linux-bcabd91c271e50eebc0cb9220ac92700332b452e.zip
tracing/filters: fix NULL pointer dereference
Try this, and you'll see NULL pointer dereference bug: # echo -n 'parent_comm ==' > sched/sched_process_fork/filter Because we passed NULL ptr to simple_strtoull(). Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> Acked-by: Tom Zanussi <tzanussi@gmail.com> Acked-by: Frederic Weisbecker <fweisbec@gmail.com> Cc: Steven Rostedt <rostedt@goodmis.org> LKML-Reference: <49E04C43.1050504@cn.fujitsu.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/trace/trace_events_filter.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index 026be412f356..9d2162fd2305 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -410,6 +410,11 @@ int filter_parse(char **pbuf, struct filter_pred *pred)
}
}
+ if (!val_str) {
+ pred->field_name = NULL;
+ return -EINVAL;
+ }
+
pred->field_name = kstrdup(pred->field_name, GFP_KERNEL);
if (!pred->field_name)
return -ENOMEM;