summaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>2016-05-23 15:06:30 -0400
committerSteven Rostedt <rostedt@goodmis.org>2016-06-20 09:46:21 -0400
commit0ded5174e976e2b2a354fe38abf1ebf4492c6dc3 (patch)
tree0422d908de6df2748eed4c3c4875f041cf1d9652 /kernel
parent70c8217acd4383e069fe1898bbad36ea4fcdbdcc (diff)
downloadlinux-0ded5174e976e2b2a354fe38abf1ebf4492c6dc3.tar.gz
linux-0ded5174e976e2b2a354fe38abf1ebf4492c6dc3.tar.bz2
linux-0ded5174e976e2b2a354fe38abf1ebf4492c6dc3.zip
ftracetest: Fix hist unsupported result in hist selftests
When histograms are not configured in the kernel, the ftracetest histogram selftests should return "unsupported" and not "Failed". To detect this, the test scripts have: FEATURE=`grep hist events/sched/sched_process_fork/trigger` if [ -z "$FEATURE" ]; then echo "hist trigger is not supported" exit_unsupported fi The problem is that '-e' is in effect and any error will cause the program to terminate. The grep for 'hist' fails, because it is not compiled it (thus unsupported), but because grep has an error code for failing to find the string, it causes the program to terminate, and is marked as a failed test. Namhyung Kim recommended to test for the "hist" file located in events/sched/sched_process_fork/hist instead, as it is more inline with the other checks. As the hist file is only created if the histogram feature is enabled, that is a valid check. Link: http://lkml.kernel.org/r/20160523151538.4ea9ce0c@gandalf.local.home Suggested-by: Namhyung Kim <namhyung@kernel.org> Acked-by: Namhyung Kim <namhyung@kernel.org> Acked-by: Masami Hiramatsu <mhiramat@kernel.org> Fixes: 76929ab51f0ee ("kselftests/ftrace: Add hist trigger testcases") Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions