summaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorChris Mason <clm@fb.com>2014-11-19 10:25:09 -0800
committerChris Mason <clm@fb.com>2014-11-19 10:34:35 -0800
commitf82c458a2c3ffb94b431fc6ad791a79df1b3713e (patch)
tree0eca3f95f74d1cde140366002b3cd794ce96f67c /kernel
parent6e5aafb27419f32575b27ef9d6a31e5d54661aca (diff)
downloadlinux-f82c458a2c3ffb94b431fc6ad791a79df1b3713e.tar.gz
linux-f82c458a2c3ffb94b431fc6ad791a79df1b3713e.tar.bz2
linux-f82c458a2c3ffb94b431fc6ad791a79df1b3713e.zip
btrfs: fix lockups from btrfs_clear_path_blocking
The fair reader/writer locks mean that btrfs_clear_path_blocking needs to strictly follow lock ordering rules even when we already have blocking locks on a given path. Before we can clear a blocking lock on the path, we need to make sure all of the locks have been converted to blocking. This will remove lock inversions against anyone spinning in write_lock() against the buffers we're trying to get read locks on. These inversions didn't exist before the fair read/writer locks, but now we need to be more careful. We papered over this deadlock in the past by changing btrfs_try_read_lock() to be a true trylock against both the spinlock and the blocking lock. This was slower, and not sufficient to fix all the deadlocks. This patch adds a btrfs_tree_read_lock_atomic(), which basically means get the spinlock but trylock on the blocking lock. Signed-off-by: Chris Mason <clm@fb.com> Signed-off-by: Josef Bacik <jbacik@fb.com> Reported-by: Patrick Schmid <schmid@phys.ethz.ch> cc: stable@vger.kernel.org #v3.15+
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions