diff options
author | Takashi Iwai <tiwai@suse.de> | 2017-05-30 09:23:41 +0200 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2017-05-31 08:46:14 +0200 |
commit | 64188cfbe5245d412de2139a3864e4e00b4136f0 (patch) | |
tree | 7551a8af8eb7594e467e6051e96ffdb81b9f02a2 /lib/nmi_backtrace.c | |
parent | 1fc2e41f7af4572b07190f9dec28396b418e9a36 (diff) | |
download | linux-64188cfbe5245d412de2139a3864e4e00b4136f0.tar.gz linux-64188cfbe5245d412de2139a3864e4e00b4136f0.tar.bz2 linux-64188cfbe5245d412de2139a3864e4e00b4136f0.zip |
Revert "ALSA: usb-audio: purge needless variable length array"
This reverts commit 89b593c30e83 ("ALSA: usb-audio: purge needless
variable length array"). The patch turned out to cause a severe
regression, triggering an Oops at snd_usb_ctl_msg(). It was overseen
that snd_usb_ctl_msg() writes back the response to the given buffer,
while the patch changed it to a read-only const buffer. (One should
always double-check when an extra pointer cast is present...)
As a simple fix, just revert the affected commit. It was merely a
cleanup. Although it brings VLA again, it's clearer as a fix. We'll
address the VLA later in another patch.
Fixes: 89b593c30e83 ("ALSA: usb-audio: purge needless variable length array")
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=195875
Cc: <stable@vger.kernel.org> # v4.11+
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'lib/nmi_backtrace.c')
0 files changed, 0 insertions, 0 deletions