diff options
author | Yury Norov <yury.norov@gmail.com> | 2022-07-23 14:45:36 -0700 |
---|---|---|
committer | Yury Norov <yury.norov@gmail.com> | 2022-08-01 08:13:21 -0700 |
commit | 3e731203153de1c06a8b7a4f15061e9051c09a6f (patch) | |
tree | 2c2713fe64d8d22a1b54adbe2df3f7ccade19d98 /lib/of-reconfig-notifier-error-inject.c | |
parent | 3a2ba42cbd0b669ce3837ba400905f93dd06c79f (diff) | |
download | linux-3e731203153de1c06a8b7a4f15061e9051c09a6f.tar.gz linux-3e731203153de1c06a8b7a4f15061e9051c09a6f.tar.bz2 linux-3e731203153de1c06a8b7a4f15061e9051c09a6f.zip |
powerpc: drop dependency on <asm/machdep.h> in archrandom.h
archrandom.h includes <asm/machdep.h> to refer ppc_md. This causes
circular header dependency, if generic nodemask.h includes random.h:
In file included from include/linux/cred.h:16,
from include/linux/seq_file.h:13,
from arch/powerpc/include/asm/machdep.h:6,
from arch/powerpc/include/asm/archrandom.h:5,
from include/linux/random.h:109,
from include/linux/nodemask.h:97,
from include/linux/list_lru.h:12,
from include/linux/fs.h:13,
from include/linux/compat.h:17,
from arch/powerpc/kernel/asm-offsets.c:12:
include/linux/sched.h:1203:9: error: unknown type name 'nodemask_t'
1203 | nodemask_t mems_allowed;
| ^~~~~~~~~~
Fix it by removing <asm/machdep.h> dependency from archrandom.h
Now as arch_get_random_seed_long() moved to c-file, and not exported,
it's not available for modules. As Michael Ellerman says:
I think we actually don't need it exported to modules, I think it's
a private detail of the RNG <-> architecture interface, not something
that modules should be calling.
CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Michael Ellerman <mpe@ellerman.id.au>
CC: Paul Mackerras <paulus@samba.org>
CC: Rasmus Villemoes <linux@rasmusvillemoes.dk>
CC: Stephen Rothwell <sfr@canb.auug.org.au>
CC: linuxppc-dev@lists.ozlabs.org
Suggested-by: Michael Ellerman <mpe@ellerman.id.au> (for non-exporting)
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Yury Norov <yury.norov@gmail.com>
Diffstat (limited to 'lib/of-reconfig-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions