summaryrefslogtreecommitdiffstats
path: root/lib/test_overflow.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2018-06-12 15:04:33 +0300
committerKees Cook <keescook@chromium.org>2018-06-12 16:19:22 -0700
commit8958fd411ba08aa3ac1aeb19828abaf9cf33f7b8 (patch)
treeabfa2ce8dcf0673866e1236b4ef59f42eb8e2f9b /lib/test_overflow.c
parentd54d35c501bcbd57b9722a6b371c0608b5d34199 (diff)
downloadlinux-8958fd411ba08aa3ac1aeb19828abaf9cf33f7b8.tar.gz
linux-8958fd411ba08aa3ac1aeb19828abaf9cf33f7b8.tar.bz2
linux-8958fd411ba08aa3ac1aeb19828abaf9cf33f7b8.zip
test_overflow: fix an IS_ERR() vs NULL bug
root_device_register() returns error pointers, it never returns NULL. Fixes: ca90800a91ba ("test_overflow: Add memory allocation overflow tests") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'lib/test_overflow.c')
-rw-r--r--lib/test_overflow.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/test_overflow.c b/lib/test_overflow.c
index aecbbb217305..2278fe05a1b0 100644
--- a/lib/test_overflow.c
+++ b/lib/test_overflow.c
@@ -367,7 +367,7 @@ static int __init test_overflow_allocation(void)
/* Create dummy device for devm_kmalloc()-family tests. */
dev = root_device_register(device_name);
- if (!dev) {
+ if (IS_ERR(dev)) {
pr_warn("Cannot register test device\n");
return 1;
}