summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2018-07-01 13:57:16 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-07-07 17:40:20 +0200
commit77d2a24b6107bd9b3bf2403a65c1428a9da83dd0 (patch)
tree764a6d3b28f02a08d12eaa295e2ba69b517e6c77 /lib
parent448a5a552f336bd7b847b1951ffd15eb2e7167a3 (diff)
downloadlinux-77d2a24b6107bd9b3bf2403a65c1428a9da83dd0.tar.gz
linux-77d2a24b6107bd9b3bf2403a65c1428a9da83dd0.tar.bz2
linux-77d2a24b6107bd9b3bf2403a65c1428a9da83dd0.zip
kobject: Replace strncpy with memcpy
gcc 8.1.0 complains: lib/kobject.c:128:3: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] lib/kobject.c: In function 'kobject_get_path': lib/kobject.c:125:13: note: length computed here Using strncpy() is indeed less than perfect since the length of data to be copied has already been determined with strlen(). Replace strncpy() with memcpy() to address the warning and optimize the code a little. Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib')
-rw-r--r--lib/kobject.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/kobject.c b/lib/kobject.c
index 18989b5b3b56..e876957743c8 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -125,7 +125,7 @@ static void fill_kobj_path(struct kobject *kobj, char *path, int length)
int cur = strlen(kobject_name(parent));
/* back up enough to print this name with '/' */
length -= cur;
- strncpy(path + length, kobject_name(parent), cur);
+ memcpy(path + length, kobject_name(parent), cur);
*(path + --length) = '/';
}