summaryrefslogtreecommitdiffstats
path: root/mm/dmapool.c
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2009-06-30 11:41:25 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2009-06-30 18:56:00 -0700
commitc49568235dd7b4a2ffad63aa950562f4ffb9455f (patch)
treefbfcc2e0ffc4a82bd9f481e1a746bfb49955800f /mm/dmapool.c
parent4d6c13f87db12ae1ce35ea6a15688ac72419b133 (diff)
downloadlinux-c49568235dd7b4a2ffad63aa950562f4ffb9455f.tar.gz
linux-c49568235dd7b4a2ffad63aa950562f4ffb9455f.tar.bz2
linux-c49568235dd7b4a2ffad63aa950562f4ffb9455f.zip
dmapools: protect page_list walk in show_pools()
show_pools() walks the page_list of a pool w/o protection against the list modifications in alloc/free. Take pool->lock to avoid stomping into nirvana. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Matthew Wilcox <willy@linux.intel.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/dmapool.c')
-rw-r--r--mm/dmapool.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/mm/dmapool.c b/mm/dmapool.c
index b1f0885dda22..3df063706f53 100644
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -86,10 +86,12 @@ show_pools(struct device *dev, struct device_attribute *attr, char *buf)
unsigned pages = 0;
unsigned blocks = 0;
+ spin_lock_irq(&pool->lock);
list_for_each_entry(page, &pool->page_list, page_list) {
pages++;
blocks += page->in_use;
}
+ spin_unlock_irq(&pool->lock);
/* per-pool info, no real statistics yet */
temp = scnprintf(next, size, "%-16s %4u %4Zu %4Zu %2u\n",