diff options
author | John David Anglin <dave.anglin@bell.net> | 2014-05-11 18:40:50 -0400 |
---|---|---|
committer | Helge Deller <deller@gmx.de> | 2014-05-15 21:12:26 +0200 |
commit | c776cd89fc705fc8b5c2e5ad906bf5d791620fed (patch) | |
tree | c6f26e9791042801f87cd36d87ebb0d527b344b1 /mm/memblock.c | |
parent | fef47e2a2e1e75fe50a10f634a80f16808348cc6 (diff) | |
download | linux-c776cd89fc705fc8b5c2e5ad906bf5d791620fed.tar.gz linux-c776cd89fc705fc8b5c2e5ad906bf5d791620fed.tar.bz2 linux-c776cd89fc705fc8b5c2e5ad906bf5d791620fed.zip |
parisc: Improve LWS-CAS performance
The attached change significantly improves the performance of the LWS-CAS code
in syscall.S.
This allows a number of packages to build (e.g., zeromq3, gtest and libxs)
that previously failed because slow LWS-CAS performance under contention. In
particular, interrupts taken while the lock was taken degraded performance
significantly.
The change does the following:
1) Disables interrupts around the CAS operation, and
2) Changes the loads and stores to use the ordered completer, "o", on
PA 2.0. "o" and "ma" with a zero offset are equivalent. The latter is
accepted on both PA 1.X and 2.0.
The use of ordered loads and stores probably makes no difference on all
existing hardware, but it seemed pedantically correct. In particular, the CAS
operation must complete before LDCW lock is released. As written before, a
processor could reorder the operations.
I don't believe the period interrupts are disabled is long enough to
significantly increase interrupt latency. For example, the TLB insert code is
longer. Worst case is a memory fault in the CAS operation.
Signed-off-by: John David Anglin <dave.anglin@bell.net>
Cc: stable@vger.kernel.org # 3.13+
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'mm/memblock.c')
0 files changed, 0 insertions, 0 deletions